Skip to content

fix: python3.13 dependencies compatibility #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Vdaleke
Copy link
Contributor

@Vdaleke Vdaleke commented Apr 8, 2025

For python 3.13 bump transformers to ^4.47, which depends on tokenizers >= 0.21, since tokenizers <0.20.2 are incompatible with python3.13.
Set macOS on x86_64 platform as incompatible with Python 3.13.
Update lock file with poetry 1.8.5.

Issue resolved by this Pull Request:
Resolves #90

Checklist:

  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

Copy link

mergify bot commented Apr 8, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@Vdaleke Vdaleke force-pushed the fix/python3.13-compatibility branch 2 times, most recently from a844f4f to d3f8d7a Compare April 9, 2025 11:01
Bump transformers to ^4.47, which depends on tokenizers >= 0.21,
since tokenizers <0.20.2 are incompatible with python3.13.
Set macOS on x86_64 platform as incompatible with Python 3.13.
Update lock file with poetry 1.8.5.

Signed-off-by: Matvei Smirnov <[email protected]>
@Vdaleke Vdaleke force-pushed the fix/python3.13-compatibility branch from d3f8d7a to 289592f Compare April 9, 2025 11:03
@Vdaleke
Copy link
Contributor Author

Vdaleke commented Apr 9, 2025

Another possible way is:

transformers = [
  {markers = "sys_platform != 'darwin' or platform_machine != 'x86_64'", version = "^4.47.0"},
  {markers = "python_version < '3.13' and sys_platform == 'darwin' and platform_machine == 'x86_64'", version = "~4.42.0"}
]

If you don't mind bumping the whole version for non-macos Intel, I can fix it.

@cbrendanprice
Copy link

respectfully, any idea when this might get reviewed/merged @cau-git?

dolfim-ibm added 2 commits May 8, 2025 19:37
Signed-off-by: Michele Dolfi <[email protected]>
@dolfim-ibm dolfim-ibm merged commit 3adaf74 into docling-project:main May 8, 2025
7 checks passed
@Vdaleke Vdaleke deleted the fix/python3.13-compatibility branch May 9, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies are incompatible with python 3.13
4 participants