activate sidebar on resetEvents #2131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no `fetch`is done, the active sidebar element is not updated when a link is clicked. This is changed in this commit by calling getAndActive in `$resetEvents`.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
trusktr
requested changes
Sep 19, 2023
There was a problem hiding this comment.
Hmm, it is still funky that it unhighlights the top level item while scrolling (highlights the hidden child item).
Can you add a test for this?
Perhaps what we should do is highlight the parent items in lighter green, and the sub item in darker green, so that the whole path is highlighted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When no
fetchis done, the active sidebar element is not updated when a link is clicked. This is changed in this commit by calling getAndActive in$resetEvents.This is shown in the videos below. In both videos, the 'QuickStart' sidebar element was selected, then the 'Initialize' sub-sidebar child of 'Quickstart' and then the parent sidebar element, 'Quickstart' again.
Current behavior
Clicking on a sub-sidebar, then clicking on the parent sidebar again results in no element being 'active' .
Screencast.from.14.07.2023.17.51.07.webm
Behavior after fix
Clicking on a sub-sidebar, then clicking on the parent sidebar again results in the sidebar element being 'active' .
Screencast.from.14.07.2023.17.50.45.webm
What kind of change does this PR introduce?
Bugfix
Does this PR introduce a breaking change? (check one)
Related issue, if any:
Tested in the following browsers: