Removed test that wasn't achieving anything.

Modified parameter test to ensure connection string is formatting per expectation.
doctrine · Nov 19, 2024 · db6428c · db6428c
1 parent 5a9b576
commit db6428c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/tests/Driver/AbstractOracleDriver/EasyConnectStringTest.php b/tests/Driver/AbstractOracleDriver/EasyConnectStringTest.php
@@ -57,6 +57,18 @@ public static function connectionParametersProvider(): iterable
                 '(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=localhost)(PORT=41521))'
                     . '(CONNECT_DATA=(SID=XE)(INSTANCE_NAME=SALES)(SERVER=POOLED)))',
             ],
+            'tcps-params' => [
+                [
+                    'host' => 'localhost',
+                    'port' => 41521,
+                    'dbname' => 'XE',
+                    'instancename' => 'SALES',
+                    'pooled' => true,
+                    'driverOptions' => ['protocol' => 'TCPS'],
+                ],
+                '(DESCRIPTION=(ADDRESS=(PROTOCOL=TCPS)(HOST=localhost)(PORT=41521))'
+                . '(CONNECT_DATA=(SID=XE)(INSTANCE_NAME=SALES)(SERVER=POOLED)))',
+            ],
         ];
     }
 }
diff --git a/tests/Driver/OCI8/DriverTest.php b/tests/Driver/OCI8/DriverTest.php
@@ -20,13 +20,6 @@ public function testPersistentAndExclusiveAreMutuallyExclusive(): void
         ]);
     }
 
-    public function testParseValidProtocol(): void
-    {
-        (new Driver())->connect([
-            'driverOptions' => ['protocol' => 'TCPS'],
-        ]);
-    }
-
     protected function createDriver(): DriverInterface
     {
         return new Driver();