Normalize column names when filtering them #6918
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes Table::getColumns not returning columns in their documented order (PK > FK > rest). Fixes doctrine#4158
morozov
reviewed
May 4, 2025
Comment on lines
+69
to
+71
| self::assertSame($columns[2], $orderedColumns[0]); | ||
| self::assertSame($columns[1], $orderedColumns[1]); | ||
| self::assertSame($columns[0], $orderedColumns[2]); |
There was a problem hiding this comment.
I'm sorry, these assertions are impossible to comprehend. What are you trying to achieve?
Regardless, the behavior of returning table columns in a non-natural order was deprecated in #4789 and removed in #4777. Instead of relying on the behavior that's going to change during the upgrade, you may want to make your code not rely on the deprecated behavior.
There was a problem hiding this comment.
My goal was to fix the inconsistent behavior seen in #4158
But I guess that will become moot if the (bugged) ordering is removed altogether 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Table::getColumns not returning columns in their documented order (PK > FK > rest).
Fixes #4158