Skip to content

Update outdated examples in documentation (schema-representation) #6970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 4.2.x
Choose a base branch
from

Conversation

WinterSilence
Copy link

@WinterSilence WinterSilence commented May 22, 2025

Q A
Type improvement
Fixed issues #6968

Summary

Fixed:

  • First argument of Table::addForeignKeyConstraint must be string
  • Comparator example fully outdated - Comparator::compare, SchemaDiff::toSql and SchemaDiff::toSaveSql not exists

Recreate PR #6969 to push single commit

|      Q       |   A
|------------- | -----------
| Type         | improvement
| Fixed issues | doctrine#6968

#### Summary

Fixed:
- First argument of `Table::addForeignKeyConstraint` must be string
- Comparator example fully outdated - `Comparator::compare`, `SchemaDiff::toSql` and `SchemaDiff::toSaveSql` not exists

Recreate PR doctrine#6969 to push single commit
Copy link
Member

@morozov morozov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not create multiple PRs for the same submission. Instead, squash the commits and force-push into the same branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants