[jivesoftware#3] fixed code review suggestions

dodikk · Jul 27, 2018 · 3c402e2 · 3c402e2
1 parent f6b855a
commit 3c402e2
Showing 1 changed file with 1 addition and 9 deletions.
diff --git a/JiveAuthenticatingHTTPProtocolDemo/JiveAuthenticatingHTTPProtocolDemo/ViewController.m b/JiveAuthenticatingHTTPProtocolDemo/JiveAuthenticatingHTTPProtocolDemo/ViewController.m
@@ -89,15 +89,8 @@ - (JAHPDidCancelAuthenticationChallengeHandler)authenticatingHTTPProtocol:(JAHPA
     self.authAlertView.alertViewStyle = UIAlertViewStyleLoginAndPasswordInput;
     [self.authAlertView show];
 
-//    JAHPDidCancelAuthenticationChallengeHandler logCancelEvent =
-//    ^void(JAHPAuthenticatingHTTPProtocol * __nonnull authenticatingHTTPProtocol,
-//          NSURLAuthenticationChallenge   * __nonnull challenge)
-//    {
-//        NSLog(@"=== JAHPDidCancelAuthenticationChallengeHandler")
-//    }
-    //return logCancelEvent;
-
     return nil;
+
 } // authenticatingHTTPProtocol:didReceiveAuthenticationChallenge:
 
 - (void)authenticatingHTTPProtocol:(JAHPAuthenticatingHTTPProtocol *)authenticatingHTTPProtocol
@@ -163,7 +156,6 @@ - (JAHPDidCancelAuthenticationChallengeHandler)authenticatingHTTPProtocol:(JAHPA
 -(void)handleAuthChallenge:(NSURLAuthenticationChallenge*)challenge
                forProtocol:(JAHPAuthenticatingHTTPProtocol*)authenticatingHTTPProtocol
 {
-    // TODO: maybe fix leaking `self`
     NSInteger cancelButtonIndex = self.authAlertView.cancelButtonIndex;
 
     [self.authAlertView dismissWithClickedButtonIndex: cancelButtonIndex