민경준 1주차 과제 #3
Open
민경준 1주차 과제 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjunhub
reviewed
Oct 1, 2024
Comment on lines
+32
to
35
| public Employee(String firstName, String lastName) { | ||
| this.firstName = firstName; | ||
| this.lastName = lastName; | ||
| } |
There was a problem hiding this comment.
여기 빌더 안에 email 필드가 빠진 이유가 궁금합니다!
There was a problem hiding this comment.
Email 필드 누락인 것 같습니다. 오류 지적 감사합니다!
jjunhub
reviewed
Oct 1, 2024
Comment on lines
+103
to
+105
| Assertions.assertThat(result1.getFirstName()).isEqualTo("민"); | ||
| Assertions.assertThat(result2).isNull(); | ||
| Assertions.assertThat(result3.getLastName()).isEqualTo("범서"); |
There was a problem hiding this comment.
assertj 메소드 사용해서 점검해주신 부분 너무 좋습니다!
|
전체적으로 잘 해내신 것 같습니다. 고생하셨습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
직원 개인별 직원 ID, 성, 이름, 이메일 필드 추가
개인별로 나이, 집주소, 직원 ID, 급여 필드 추가
전부 출력하는 findAll()은 아직은 출력이 안되는 것 같습니다.