Skip to content

Commit

Permalink
Merge pull request pharo-project#16339 from jbrichau/16338-ZnMimePart…
Browse files Browse the repository at this point in the history
…hasHeaders-breaks-in-Pharo-12

ZnHeaders does not understand isNotEmpty
  • Loading branch information
Ducasse authored Mar 23, 2024
2 parents c6db59f + eaa722e commit 730d640
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
17 changes: 17 additions & 0 deletions src/Zinc-HTTP/ManifestZincHTTP.class.st
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
"
Please describe the package using the class comment of the included manifest class. The manifest class also includes other additional metadata for the package. These meta data are used by other tools such as the SmalllintManifestChecker and the critics Browser
"
Class {
#name : 'ManifestZincHTTP',
#superclass : 'PackageManifest',
#category : 'Zinc-HTTP-Manifest',
#package : 'Zinc-HTTP',
#tag : 'Manifest'
}

{ #category : 'code-critics' }
ManifestZincHTTP class >> ruleNotEliminationRuleV1FalsePositive [

<ignoreForCoverage>
^ #(#(#(#RGMethodDefinition #(#ZnMimePart #hasHeaders #false)) #'2024-03-23T16:05:34.582387+01:00') )
]
2 changes: 1 addition & 1 deletion src/Zinc-HTTP/ZnMimePart.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ ZnMimePart >> hasEntity [
{ #category : 'testing' }
ZnMimePart >> hasHeaders [

^ headers isNotNil and: [ self headers isNotEmpty ]
^ headers isNotNil and: [ self headers isEmpty not ]
]

{ #category : 'comparing' }
Expand Down

0 comments on commit 730d640

Please sign in to comment.