Swap sqlalchemy.utils unquote_plus for urllib.parse unquote_plus in progress_sa/pyodbc.py #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 23, 2023 11:05
…names that werent being taken into account into ischema_names dict
… oe as timestamp and must map correctly to postgres
… for variation in drive name and update readme with instructions to do so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in my testing that using this dialect with SQLAlchemy when it is above version 2.0 does not work as the unquote_plus method is no longer supported. I have changed the file to utilize the urllibs.parse version of unquote_plus, which should be future proof as it is part of the standard library.