Skip to content

Launch template explicitly disables public IPs #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Launch template explicitly disables public IPs #334

wants to merge 2 commits into from

Conversation

miguelhar
Copy link
Collaborator

@miguelhar miguelhar commented Feb 19, 2025 •
edited
Loading

There are customers in gov cloud who are enforcing

The policy (PreventEC2LaunchWithPublicIP) denies any EC2 instance launch if the instance requests a public IP (ec2:AssociatePublicIpAddress=true)

as per this issue aws/karpenter-provider-aws#3815
it is best practice to set it explicitly which led to moving the security group to the network_interface section, see : hashicorp/terraform-provider-aws#4570

@miguelhar miguelhar requested a review from a team as a code owner February 19, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddl-dclegg ddl-dclegg ddl-dclegg approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miguelhar @ddl-dclegg