Handled builds that are not associated to polled changes #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display basic info (rev + date) when possible.
tdesveaux
approved these changes
Mar 6, 2024
| ? <DNEGridChange change={change} | ||
| showDetails={changeIsExpandedByChangeId.get(change.changeid) ?? false} | ||
| setShowDetails={(show: boolean) => changeIsExpandedByChangeId.set(change.changeid, show)} | ||
| /> | ||
| : "ChangeNotFound" | ||
| : changeid.length !=0 && builds.length != 0 // The change wasn't polled, pull what we can from earliest build |
There was a problem hiding this comment.
Maybe this could be handled in DNEGridChangeNotFound?
| @@ -3,7 +3,7 @@ import './DNEGridView.scss'; | |||
| import {ObservableMap, observable} from "mobx"; | |||
| import {observer, useLocalObservable} from "mobx-react"; | |||
| import {Link, useSearchParams} from "react-router-dom"; | |||
| import {Form} from "react-bootstrap"; | |||
| import {Form, OverlayTrigger, Popover} from "react-bootstrap"; | |||
| placement="top" | ||
| overlay={popoverWithText("date-" + changeid, dateFormat(timestamp))} | ||
| > | ||
| <span><br/>{durationFromNowFormat(timestamp, now)}</span> |
There was a problem hiding this comment.
the <br/> should probably be between the two OverlayTrigger?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It sometimes happen that some submits/commits are not polled properly, just try to handle those cases.
Display basic info (rev + date) when possible.
Tells that there is no change to be found when hovering info.
I think we want to broaden what we poll to minimize the issue though.
Here is an example (left uses pr, right is vanilla)
