Feat/support search and replace #780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Disable Ctrl-F shortcuts in the code editor to avoid conflicts with the default behavior of the browser - Add keyboard navigation support to the search input box (up and down arrows and return keys) - Optimize the UI layout of the search tab, including adjusting the width and spacing of the input box - Change the close button icon from ChevronDown to a more intuitive X icon
|
🎊 PR Preview has been successfully built and deployed to https://doocs-md-preview-pr-780.surge.sh
|
|
@syhxzzz 很不错哦👍 搜索框目前放在了右上角，似乎离编辑区有点远，能否直接悬浮在编辑区上？ |
quiet-river
reviewed
May 28, 2025
quiet-river
reviewed
May 28, 2025
quiet-river
reviewed
May 28, 2025
|
修改了组件 |
yanglbme
reviewed
May 29, 2025
|
还有一个点，按 esc 的时候，搜索框能否消失？就是不需要每次点击 x，才能让搜索框隐藏。@syhxzzz |
可以调整下，简单做下适配 |
开着devtools会导致编辑栏的宽度不够，这样SearchTab也没有足够的宽度空间来容纳这么多东西。所以我一开始是没有放在编辑栏里面的。 |
|
左侧的箭头，调整下就好，现在我看着是显示不全 |
|
因为宽度空间不够才会导致显示不全。所以只能削减宽度大小 |
… the search interface - Add ESC key monitoring to CodemirrorEditor to close the search tab - Optimize the SearchTab component and add sliding animation effects - Simplify checkMatchNumber function logic - Adjust the width of the search box and add placeholder text
|
之前代码是 |
|
我觉得placeholder这个方法不错，目前的场景看起来简单有效。如果要做更灵活更复杂的适配的话，可以考虑根据宽度把放不下的操作收到一个按钮里面，点击按钮再展示其他操作。 |
|
截止目前的代码，整体效果挺好的，考虑合并，看看还有没有要改的？@syhxzzz @quiet-river |
|
我先合并，有进一步修改，可以再另外提 pr |
yanglbme
approved these changes
May 29, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#776
SearchTab，可以在里面输入搜索词和替换词，可以上下选择选中的搜索词进行跳转，或者替换成其他词