Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added region validation #359

Merged
merged 4 commits into from
Jan 29, 2025
Merged

Added region validation #359

merged 4 commits into from
Jan 29, 2025

Conversation

pedromcp90
Copy link
Member

Required by

Changelog

  • Added region validation in order to avoid saving the default value.

@pedromcp90 pedromcp90 self-assigned this Jan 29, 2025
davidmolinacano
davidmolinacano approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@davidmolinacano davidmolinacano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job!! 👍 🏆 🎖️

@eduardogomez97 eduardogomez97 self-requested a review January 29, 2025 11:57
@pedromcp90 pedromcp90 merged commit 6dc067f into master Jan 29, 2025
4 checks passed
@pedromcp90 pedromcp90 deleted the pedro/validate-region branch January 29, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardogomez97 eduardogomez97 eduardogomez97 approved these changes

@davidmolinacano davidmolinacano davidmolinacano approved these changes

Assignees

@pedromcp90 pedromcp90

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pedromcp90 @eduardogomez97 @davidmolinacano