Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multiclient to handle non unique IDs #43

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hatkirby
Copy link

This fixes a crash that occurs when loading a datapackage that has non-unique item/location IDs in it. (ArchipelagoMW/Archipelago#3394)

@doshyw
Copy link
Owner

doshyw commented Aug 26, 2024

Looks good, I developed a fix for the IReceivedItemsHelper separately already, but I missed the IDataStorageHelper. I'll get that merged in shortly. Thanks!

@hatkirby
Copy link
Author

Cool! I figured you were probably aware of it already, but I had to fix this for a multiworld I'm participating in, so I figured I might as well contribute it back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants