Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow's build's changes #48

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Allow previously collected strawberries to show up red when recollected.
  • Loading branch information
arrowbounce committed Dec 9, 2024
commit 70b982432d04c60b0129745ee2d69efd9b0a9f87
2 changes: 1 addition & 1 deletion PatchedObjects/PatchedStrawberry.cs
Original file line number Diff line number Diff line change
@@ -58,7 +58,7 @@ private static void orig_OnCollect(orig_Strawberry_orig_OnCollect orig, Strawber
ArchipelagoController.Instance.ProgressionSystem.OnCollectedClient(SaveData.Instance.CurrentSession_Safe.Area, CollectableType.STRAWBERRY, self.ID); // NEW
Session session = (self.Scene as Level).Session;
session.DoNotLoad.Add(self.ID);
// session.Strawberries.Add(self.ID);
session.Strawberries.Add(self.ID);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these re-enabled? The collect index one for the 1-Up should be fine, but I don't think we want previously-collected strawberries to be red, that seems confusing for the player

Copy link
Collaborator Author

@arrowbounce arrowbounce Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is related to the berry tracker patch above. The place that this makes the berries show up red is on that tracker, not on the in-game entity, without this the in-game berry tracker straight up doesn't work. Previously collected berries will still be ghost-ish in world.

session.UpdateLevelStartDashes();
self.Add(new Coroutine(strawberry.Invoke<IEnumerator>("CollectRoutine", collectIndex)));
}