Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward customDirectives in client preset to support Apollo unmask directive #10268

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

eddeee888
Copy link
Collaborator

Description

This is a continuation of #10163

Related issue #10245

The previous PR added support for unmask directive in typescript-operations. However, we need to forward it to the client preset for it to take effect. This PR adds that and unit test that covers the recommended config:

presetConfig: { fragmentMasking: false },
config: {
  inlineFragmentTypes: 'mask',
  customDirectives: { apolloUnmask: true },
},

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit test

Copy link

changeset-bot bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: aec6d85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/client-preset Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 22, 2025

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-codegen/cli 5.0.4-alpha-20250127064355-aec6d8586008f8d2da37dbb9b7a9ccb130ccf8b1 npm ↗︎ unpkg ↗︎
@graphql-codegen/visitor-plugin-common 5.6.1-alpha-20250127064355-aec6d8586008f8d2da37dbb9b7a9ccb130ccf8b1 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-document-nodes 4.0.13-alpha-20250127064355-aec6d8586008f8d2da37dbb9b7a9ccb130ccf8b1 npm ↗︎ unpkg ↗︎
@graphql-codegen/gql-tag-operations 4.0.13-alpha-20250127064355-aec6d8586008f8d2da37dbb9b7a9ccb130ccf8b1 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-operations 4.4.1-alpha-20250127064355-aec6d8586008f8d2da37dbb9b7a9ccb130ccf8b1 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-resolvers 4.4.2-alpha-20250127064355-aec6d8586008f8d2da37dbb9b7a9ccb130ccf8b1 npm ↗︎ unpkg ↗︎
@graphql-codegen/typed-document-node 5.0.13-alpha-20250127064355-aec6d8586008f8d2da37dbb9b7a9ccb130ccf8b1 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript 4.1.3-alpha-20250127064355-aec6d8586008f8d2da37dbb9b7a9ccb130ccf8b1 npm ↗︎ unpkg ↗︎
@graphql-codegen/client-preset 4.6.0-alpha-20250127064355-aec6d8586008f8d2da37dbb9b7a9ccb130ccf8b1 npm ↗︎ unpkg ↗︎
@graphql-codegen/graphql-modules-preset 4.0.13-alpha-20250127064355-aec6d8586008f8d2da37dbb9b7a9ccb130ccf8b1 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Jan 22, 2025

💻 Website Preview

The latest changes are available as preview in: https://d1916265.graphql-code-generator.pages.dev

Copy link
Contributor

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side! Thanks for fixing this.

@eddeee888 eddeee888 force-pushed the fwd-custom-directives-client-preset branch from 7c7e465 to e648726 Compare January 27, 2025 06:05
@eddeee888 eddeee888 merged commit 8737dd8 into master Jan 27, 2025
19 checks passed
@eddeee888 eddeee888 deleted the fwd-custom-directives-client-preset branch January 27, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants