Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split examples test for speed #10271

Merged
merged 6 commits into from
Jan 28, 2025
Merged

Split examples test for speed #10271

merged 6 commits into from
Jan 28, 2025

Conversation

eddeee888
Copy link
Collaborator

@eddeee888 eddeee888 commented Jan 26, 2025

Description

Examples test is taking ~9mins and is the longest step in the pipeline:

Screenshot 2025-01-27 at 1 04 25 PM

A quick look showed us that:

  • We needed to build SWC which takes ~4mins...
  • But was only used for 1 or 2 SWC tests

So, we can speed up CI by splitting the Examples tests to 2 parts:

  • "normal" packages a.k.a packages without @graphql-codegen/client-preset-swc-plugin dep
  • "swc" packages a.k.a. packages with @graphql-codegen/client-preset-swc-plugin dep

This change also keeps the default behaviour where example commands target all examples a.k.a "all" packages

Result: Testing workflow takes ~5min . Meaning 44% reduction in CI time! (and makes me 100% happier)

Screenshot 2025-01-27 at 1 05 16 PM

Copy link

changeset-bot bot commented Jan 26, 2025

⚠️ No Changeset found

Latest commit: f029050

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 26, 2025

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-codegen/cli 5.0.4-alpha-20250127071942-f029050859efda5c0812a4d36da0391af2b38b57 npm ↗︎ unpkg ↗︎
@graphql-codegen/visitor-plugin-common 5.6.1-alpha-20250127071942-f029050859efda5c0812a4d36da0391af2b38b57 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-document-nodes 4.0.13-alpha-20250127071942-f029050859efda5c0812a4d36da0391af2b38b57 npm ↗︎ unpkg ↗︎
@graphql-codegen/gql-tag-operations 4.0.13-alpha-20250127071942-f029050859efda5c0812a4d36da0391af2b38b57 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-operations 4.4.1-alpha-20250127071942-f029050859efda5c0812a4d36da0391af2b38b57 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript-resolvers 4.4.2-alpha-20250127071942-f029050859efda5c0812a4d36da0391af2b38b57 npm ↗︎ unpkg ↗︎
@graphql-codegen/typed-document-node 5.0.13-alpha-20250127071942-f029050859efda5c0812a4d36da0391af2b38b57 npm ↗︎ unpkg ↗︎
@graphql-codegen/typescript 4.1.3-alpha-20250127071942-f029050859efda5c0812a4d36da0391af2b38b57 npm ↗︎ unpkg ↗︎
@graphql-codegen/client-preset 4.6.0-alpha-20250127071942-f029050859efda5c0812a4d36da0391af2b38b57 npm ↗︎ unpkg ↗︎
@graphql-codegen/graphql-modules-preset 4.0.13-alpha-20250127071942-f029050859efda5c0812a4d36da0391af2b38b57 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Jan 27, 2025

💻 Website Preview

The latest changes are available as preview in: https://d709fb2f.graphql-code-generator.pages.dev

@eddeee888 eddeee888 marked this pull request as ready for review January 27, 2025 02:11
@eddeee888 eddeee888 merged commit 0b79aa6 into master Jan 28, 2025
20 checks passed
@eddeee888 eddeee888 deleted the split-examples-test branch January 28, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant