This repository was archived by the owner on Aug 20, 2024. It is now read-only.
Correctly pass default or user-defined value of similarity threshold to LocalEmbedder for Smart ComboBox #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to LocalEmbedder for Smart ComboBox
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smart ComboBox always posts 5 (integer) as the value of similarity threshold. This prevents the MVC Razor Pages example to work properly (no suggestions are presented). The sample code is (quickly) fixed by getting the POSTed value of
similarityThresholdparameter and converting it tofloatusing the expected format provider.Addresses #64 for the MVC Razor Pages sample code. #64 still needs to be fixed internally.