Add MsBuildArgument constructor supporting multiple values #2732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
|
I would rather something like this be implemented as a new type |
- Introduced MsBuildProperty class inheriting from MsBuildArgument that wraps multiple values in quotes and separates them with semicolons. - AddedtestMsBuildProperty_ShouldWrapMultipleValuesInQuotes to verify correct text representation formatting.
timcassell
reviewed
May 21, 2025
Comment on lines
+64
to
+76
|
|
||
| public MsBuildArgument(string key, params string[] values) | ||
| : base($"/p:{key}={EscapeAndJoin(values)}") { } | ||
|
|
||
| private static string EscapeAndJoin(string[] values) | ||
| { | ||
| return string.Join("%3b", values.Select(EscapeSpecialChars)); | ||
| } | ||
|
|
||
| private static string EscapeSpecialChars(string input) | ||
| { | ||
| return input.Replace(";", "%3B"); | ||
| } |
There was a problem hiding this comment.
Suggested change
| public MsBuildArgument(string key, params string[] values) | |
| : base($"/p:{key}={EscapeAndJoin(values)}") { } | |
| private static string EscapeAndJoin(string[] values) | |
| { | |
| return string.Join("%3b", values.Select(EscapeSpecialChars)); | |
| } | |
| private static string EscapeSpecialChars(string input) | |
| { | |
| return input.Replace(";", "%3B"); | |
| } |
timcassell
reviewed
May 21, 2025
| public class MsBuildProperty : MsBuildArgument | ||
| { | ||
| public MsBuildProperty(string key, params string[] values) | ||
| : base($"/p:{key}=\"{string.Join(";", values)}") |
There was a problem hiding this comment.
It seems that quotes need to be escaped to work cross-platform.
Suggested change
| : base($"/p:{key}=\"{string.Join(";", values)}") | |
| : base($"/p:{key}=\\\"{string.Join(";", values)}\\\"") |
timcassell
reviewed
May 21, 2025
| @@ -24,6 +24,13 @@ public void ProcessIsBuiltWithCustomProperty(bool setCustomProperty) | |||
| CanExecute<PropertyDefine>(config); | |||
| } | |||
|
|
|||
| [Fact] | |||
|
|
|||
| public void MsBuildProperty_ShouldWrapMultipleValuesInQuotes() | |||
There was a problem hiding this comment.
Please move this test to BenchmarkDotNet.Tests project, and add a real integration test in BenchmarkDotNet.IntegrationTests project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added MsBuildArgument(string key, params string[] values) constructor.
Implemented escaping of semicolons in argument values.