Use script to install ARM version of .NET on ARM because of a UseDotNet bug #3037
+95
−41
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| ################################################################################# | ||
| # Licensed to the .NET Foundation under one or more agreements. # | ||
| # The .NET Foundation licenses this file to you under the MIT license. # | ||
| # See the LICENSE file in the project root for more information. # | ||
| ################################################################################# | ||
| parameters: | ||
| - name: version | ||
| type: number | ||
| default: 9 | ||
| - name: sdk | ||
|
There was a problem hiding this comment. Why not just have this as a string with values of 'sdk' and 'runtime' - that way when it's passed into the later tasks, we don't have to have if expressions |
||
| type: boolean | ||
| default: false | ||
| - name: windowsArchitecture # This is only used on Windows | ||
| type: string | ||
| default: '<auto>' | ||
| values: | ||
| - '<auto>' | ||
| - 'x86' | ||
| - 'x64' | ||
| - 'arm' | ||
| - 'arm64' | ||
| - name: installDir | ||
| type: string | ||
| default: '' | ||
| - name: usePreview | ||
| type: boolean | ||
| default: false | ||
|
|
||
| # Reason for not using UseDotNet task: | ||
| # "[BUG]: UseDotNet task installs x86 build on Windows arm64" | ||
| # https://github.com/microsoft/azure-pipelines-tasks/issues/20300 | ||
| # | ||
| # Borrowed from: https://github.com/microsoft/PowerToys/blob/main/.pipelines/v2/templates/steps-ensure-dotnet-version.yml | ||
| steps: | ||
| - powershell: |- | ||
| Invoke-WebRequest -Uri "https://dot.net/v1/dotnet-install.ps1" -OutFile "dotnet-install.ps1" | ||
| $NEW_DOTNET_ROOT = "${{parameters.installDir}}" | ||
|
|
||
| if ('${{parameters.installDir}}' -eq '') { | ||
| $NEW_DOTNET_ROOT = "$(Agent.ToolsDirectory)\dotnet" | ||
| } else { | ||
| $NEW_DOTNET_ROOT = "${{parameters.installDir}}" | ||
| } | ||
|
|
||
| if (!$${{parameters.sdk}}) { | ||
| $runtime = "dotnet" | ||
| } | ||
|
|
||
| $quality = "GA" | ||
| if ($${{parameters.usePreview}}) { | ||
| $quality = "preview" | ||
| } | ||
|
|
||
| & ./dotnet-install.ps1 -Channel "${{parameters.version}}.0" -Quality $quality -InstallDir $NEW_DOTNET_ROOT -Runtime $runtime -Architecture "${{parameters.windowsArchitecture}}" | ||
| Write-Host "##vso[task.setvariable variable=DOTNET_ROOT]${NEW_DOTNET_ROOT}" | ||
| Write-Host "##vso[task.prependpath]${NEW_DOTNET_ROOT}" | ||
| Remove-Item dotnet-install.ps1 -ErrorAction:Ignore | ||
| condition: and(succeeded(), eq(variables['Agent.OS'], 'Windows_NT')) | ||
|
There was a problem hiding this comment. How about instead of doing this as a condition buried in the task definition, let's move this a level higher and use the |
||
| ${{ if eq(parameters.sdk, true) }}: | ||
| displayName: "Install .NET ${{parameters.version}} SDK (Win)" | ||
| ${{ else }}: | ||
| displayName: "Install .NET ${{parameters.version}} (Win)" | ||
| - task: UseDotNet@2 | ||
| inputs: | ||
| ${{ if eq(parameters.sdk, true) }}: | ||
| packageType: sdk | ||
| ${{ else }}: | ||
| packageType: runtime | ||
| version: '${{parameters.version}}.x' | ||
| ${{ if ne(parameters.installDir, '') }}: | ||
| installationPath: '${{parameters.installDir}}' | ||
| includePreviewVersions: ${{parameters.usePreview}} | ||
| condition: and(succeeded(), ne(variables['Agent.OS'], 'Windows_NT')) | ||
| ${{ if eq(parameters.sdk, true) }}: | ||
| displayName: "Install .NET ${{parameters.version}} SDK (non-Win)" | ||
| ${{ else }}: | ||
| displayName: "Install .NET ${{parameters.version}} (non-Win)" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're working on improving our pipelines (and I'm pushing for some degree of uniformity), can we have these with: