Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Password for Garnet #7618

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Alirexaa
Copy link
Contributor

@Alirexaa Alirexaa commented Feb 14, 2025

Description

The implementation is based on https://microsoft.github.io/garnet/docs/security#password-protected-sessions.
Also, I override the entrypoint from /app/GarnetServer to /bin/sh to provide the password from environment variables.

Contributes to #6155

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • x ] Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Feb 14, 2025
@danmoseley danmoseley added area-integrations Issues pertaining to Aspire Integrations packages security 🔐 labels Feb 14, 2025
@davidfowl
Copy link
Member

Lets make sure we get the redis implementation working and merge end to end (including deployment to azure with azd) before we review this one. Unlike redis, we can influence garnet to add an env variable instead of using arguments 😄 for passwords.

cc @ReubenBond

@danmoseley danmoseley added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-integrations Issues pertaining to Aspire Integrations packages community-contribution Indicates that the PR has been added by a community member NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) security 🔐
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants