Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to FluentUI 4.11.5. Changes are to fix component tests which need to handle new JS modules and invocations.
@vnbaaij A test has started failing after the update:
ResourceName_MultiRender_SubscribeConsoleLogsOnce
. I debugged what was different between 4.11.3 and 4.11.5 and found that for some reason theResourceSelect.SelectedResource
value is reset back to the default empty option. It's bound here:aspire/src/Aspire.Dashboard/Components/Pages/ConsoleLogs.razor
Line 26 in 1be1ad5
That change then triggers
HandleSelectedOptionChangedAsync
, which sets the selected resource property back to null. And then the assert on the selected resource property fails:aspire/tests/Aspire.Dashboard.Components.Tests/Pages/ConsoleLogsTests.cs
Line 75 in 1be1ad5
I don't understand why it started happening in 4.11.5.
Checklist
<remarks />
and<code />
elements on your triple slash comments?breaking-change
template):doc-idea
template):