Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to FluentUI 4.11.5 #7681

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Feb 19, 2025

Description

Update to FluentUI 4.11.5. Changes are to fix component tests which need to handle new JS modules and invocations.

@vnbaaij A test has started failing after the update: ResourceName_MultiRender_SubscribeConsoleLogsOnce. I debugged what was different between 4.11.3 and 4.11.5 and found that for some reason the ResourceSelect.SelectedResource value is reset back to the default empty option. It's bound here:

@bind-SelectedResource="PageViewModel.SelectedOption"

That change then triggers HandleSelectedOptionChangedAsync, which sets the selected resource property back to null. And then the assert on the selected resource property fails:

cut.WaitForState(() => instance.PageViewModel.SelectedResource == testResource);

I don't understand why it started happening in 4.11.5.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@Copilot Copilot bot review requested due to automatic review settings February 19, 2025 08:52

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • Directory.Packages.props: Language not supported
  • tests/Aspire.Dashboard.Components.Tests/Pages/ConsoleLogsTests.cs: Evaluated as low risk
Comments suppressed due to low confidence (2)

tests/Aspire.Dashboard.Components.Tests/Pages/TraceDetailsTests.cs:165

  • Ensure that the behavior introduced by removePreventArrowKeyNavigation is covered by tests.
toolbarModule.SetupVoid("removePreventArrowKeyNavigation", _ => true);

tests/Aspire.Dashboard.Components.Tests/Shared/MetricsSetupHelpers.cs:5

  • Inconsistent handling of version in file path. Use GetFluentFile method to ensure uniform version management.
_ = context.JSInterop.SetupModule("/Components/Controls/Chart/MetricTable.razor.js");
@vnbaaij
Copy link
Contributor

vnbaaij commented Feb 19, 2025

I need to debug this.

@JamesNK
Copy link
Member Author

JamesNK commented Feb 19, 2025

I need to debug this.

Thanks. I spent an hour looking at it but when I saw the binded value get reset from deep inside Blazor logic I felt out of my depth.

Let me know if you need more info or help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants