Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] re-enable windows non-helix tests on public pipeline rolling builds #7701

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

radical
Copy link
Member

@radical radical commented Feb 20, 2025

Issue: ##[error]Artifact Windows_CodeCoverageResults was not found for build ....

The underlying problem is that pipeline (non-helix) tests are not being run on Windows at all, since the recent pipeline changes. This was detected now due to the above error because all other tests are passing now, and the CodeCoverage step is run which failed because no codecoverage results were found for windows.

@Copilot Copilot bot review requested due to automatic review settings February 20, 2025 00:52

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@radical
Copy link
Member Author

radical commented Feb 20, 2025

@radical radical requested a review from mitchdenny as a code owner February 20, 2025 01:21
@radical
Copy link
Member Author

radical commented Feb 20, 2025

Another run after adding a missing RequiresDocker on a test: https://dev.azure.com/dnceng-public/public/_build/results?buildId=957283&view=results

Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's see if it works

@danmoseley danmoseley enabled auto-merge (squash) February 20, 2025 02:26
@radical
Copy link
Member Author

radical commented Feb 20, 2025

ugh.. something else to check. Don't merge yet :|

@danmoseley danmoseley merged commit 9440865 into dotnet:main Feb 20, 2025
70 checks passed
@radical radical deleted the fix-code-cov-win branch February 20, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants