[release/9.1] Don't set properties on existing Azure SQL server resources #7707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7705 to release/9.1
/cc @captainsafia
Customer Impact
This PR updates the bicep generated for existing Azure SQL resources to avoid mutating properties on existing resources. It uses a workaround to model the administrator access for the managed identity as an "edge" between the parent SqlServer resource and a custom SqlServerAzureADAdministrator resource.
Without this change, the generated Bicep is invalid and will fail to provision the resource correctly.
Testing
Risk
Low, affects Azure SQL services only and avoid errors during provisioning with current implemenation.
Regression?
No.