Review feedback for Azure.EFCore.Npgsql integration

[sebastienros]

Description

Applying remaining feedback from #8354

Checklist

• Is this feature complete?
  • Yes. Ready to ship.
  • No. Follow-up changes expected.
• Are you including unit tests for the changes and scenario tests if relevant?
  • Yes
  • No
• Did you add public API?
  • Yes
    • If yes, did you have an API Review for it?
      • Yes
      • No
    • Did you add <remarks /> and <code /> elements on your triple slash comments?
      • Yes
      • No
  • No
• Does the change make any security assumptions or guarantees?
  • Yes
    • If yes, have you done a threat model and had a security review?
      • Yes
      • No
  • No
• Does the change require an update in our Aspire docs?
  • Yes
    • Is this introducing a breaking change?
      • Yes
        • Link to aspire-docs issue (please use this breaking-change template):
      • No
        • Link to aspire-docs issue (please use this doc-idea template):
  • No

[Copilot]

Pull Request Overview

This PR applies remaining feedback for the Azure.EFCore.Npgsql integration by refactoring the authentication configuration logic and updating test dependencies. Key changes include:

• Adding missing test dependency references for Npgsql tests.
• Removing the workaround file (WorkaroundToReadProtectedField) no longer needed.
• Refactoring authentication configuration by introducing the ConfigureEntraIdAuthentication extension method and updating usage across projects with NET9_0_OR_GREATER conditional support.

Reviewed Changes

Copilot reviewed 8 out of 21 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/Aspire.Npgsql.EntityFrameworkCore.PostgreSQL.Tests/AspireEFPostgreSqlExtensionsTests.cs	Added missing using for Npgsql test utilities.
tests/Aspire.Azure.Npgsql.EntityFrameworkCore.PostgreSQL.Tests/WorkaroundToReadProtectedField.cs	Removed obsolete workaround for reading protected fields.
tests/Aspire.Azure.Npgsql.EntityFrameworkCore.PostgreSQL.Tests/AspireAzureEFPostgreSqlExtensionsTests.cs	Added missing using for Npgsql test utilities.
src/Components/Common/ManagedIdentityTokenCredentialHelpers.cs	Refactored to expose the ConfigureEntraIdAuthentication extension method for credential setup.
src/Components/Common/EntityFrameworkUtils.cs	Minor formatting change introduced.
src/Components/Aspire.Azure.Npgsql/AspireAzureNpgsqlExtensions.cs	Updated to use the new authentication extension method.
src/Components/Aspire.Azure.Npgsql.EntityFrameworkCore.PostgreSQL/AspireAzureEFPostgreSqlExtensions.cs	Updated authentication configuration logic with conditional compilation for NET9_0_OR_GREATER.

Files not reviewed (13)

• playground/PostgresEndToEnd/PostgresEndToEnd.ApiService/PostgresEndToEnd.ApiService.csproj: Language not supported
• playground/TestShop/CatalogDb/CatalogDb.csproj: Language not supported
• playground/TestShop/CatalogModel/CatalogModel.csproj: Language not supported
• playground/TestShop/CatalogService/CatalogService.csproj: Language not supported
• playground/bicep/BicepSample.ApiService/BicepSample.ApiService.csproj: Language not supported
• playground/cdk/CdkSample.ApiService/CdkSample.ApiService.csproj: Language not supported
• playground/publishers/Publishers.ApiService/Publishers.ApiService.csproj: Language not supported
• playground/publishers/Publishers.DbSetup/Publishers.DbSetup.csproj: Language not supported
• playground/waitfor/WaitForSandbox.ApiService/WaitForSandbox.ApiService.csproj: Language not supported
• playground/waitfor/WaitForSandbox.DbSetup/WaitForSandbox.DbSetup.csproj: Language not supported
• src/Components/Aspire.Npgsql.EntityFrameworkCore.PostgreSQL/Aspire.Npgsql.EntityFrameworkCore.PostgreSQL.csproj: Language not supported
• tests/Aspire.Azure.Npgsql.EntityFrameworkCore.PostgreSQL.Tests/Aspire.Azure.Npgsql.EntityFrameworkCore.PostgreSQL.Tests.csproj: Language not supported
• tests/Aspire.Npgsql.EntityFrameworkCore.PostgreSQL.Tests/Aspire.Npgsql.EntityFrameworkCore.PostgreSQL.Tests.csproj: Language not supported

[sebastienros]

@roji The test  Aspire.Azure.Npgsql.EntityFrameworkCore.PostgreSQL.Tests.TokenCredentialTests.ReadsUsernameFromManagedIdentityToken(useEnrich: True) works fine in isolation in net9.0, when using ConfigureDataSource, but when it's executed with others then it fails. The connection string doesn't have the username set with the builder from the ConfigureDataSource.

Any idea?

Update: I removed the use of ConfigureDataSource for tests to work: 621bb59

[roji]

@sebastienros can you point me to the test or minimal repro and the failure so I have more context?

[eerhardt]

LGTM. I have a few nits, but the code changes are good.