Fix hosting exception during startup when CTRL+C #8886
+36
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
|
It would be good to get a test case that covers triggering the cancellation token to simulate CTRL-C to make sure that the host does in fact shut down cleanly. |
|
@dotnet-policy-service agree |
|
Not fully sure I wrote the test correctly but it seems to do simulate CTRL+C. |
mitchdenny
reviewed
Apr 21, 2025
| @@ -130,6 +130,10 @@ public async Task RunApplicationAsync(CancellationToken cancellationToken = defa | |||
|
|
|||
| await CreateContainersAndExecutablesAsync(cancellationToken).ConfigureAwait(false); | |||
| } | |||
| catch (OperationCanceledException) when (cancellationToken.IsCancellationRequested) | |||
| { | |||
| // This is here so hosting does not throw an exception when CTRL+C during startup. | |||
There was a problem hiding this comment.
Would also be good to log a message here.
There was a problem hiding this comment.
I assume LogDebug should be used based on other log calls in the same file, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
catch (OperationCanceledException)inDcpExecutor.csfile to fixSystem.OperationCanceledException: The operation was canceled.that happens during startup when container runtimedockeris unhealthy and user pressed CTRL+C.Fixes #8838
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate