Allow scheme to be specified when configuring Azurite #9570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances Azurite configuration by allowing the scheme to be specified when building endpoints, rather than hardcoding "http".
- Updated endpoints in the AzureStorageExtensions to accept a scheme parameter
- Modified the connection string generation to use the configured scheme
- Adjusted tests to verify the new scheme setting
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/Aspire.Hosting.Azure.Tests/AzureStorageExtensionsTests.cs | Added verification for the scheme configuration in tests |
| src/Aspire.Hosting.Azure.Storage/AzureStorageExtensions.cs | Updated endpoint configuration to accept a scheme |
| src/Aspire.Hosting.Azure.Storage/AzureStorageEmulatorConnectionString.cs | Modified connection string generation to include scheme |
github-actions
bot
added
the
area-integrations
dotnet-policy-service
bot
added
the
community-contribution
davidfowl
approved these changes
May 30, 2025
davidfowl
previously requested changes
May 30, 2025
dotnet-policy-service
bot
added
the
needs-author-action
davidfowl
reviewed
May 30, 2025
MatthewSteeples
force-pushed
the
azuriteHttps
branch
from
740ef15 to
111378b
Compare
dotnet-policy-service
bot
removed
the
needs-author-action
davidfowl
approved these changes
May 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of the work involved for #9381
Currently
httpis hardcoded when Aspire is configured to use Azurite. This change moves that into default configuration and allows it to be customised.Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate