Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch DataTestMethod to TestMethod #43783

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Switch DataTestMethod to TestMethod #43783

merged 3 commits into from
Nov 27, 2024

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Nov 27, 2024 •
edited by github-actions bot
Loading

@dotnetrepoman dotnetrepoman bot added this to the November 2024 milestone Nov 27, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Nov 27, 2024
@Youssef1313 Youssef1313 marked this pull request as ready for review November 27, 2024 04:52
@Youssef1313 Youssef1313 requested review from IEvangelist and a team as code owners November 27, 2024 04:52
BillWagner
BillWagner approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Youssef1313

This looks great, and I'll :shipit: now.

@BillWagner BillWagner merged commit 1095be2 into dotnet:main Nov 27, 2024
9 checks passed
@Youssef1313 Youssef1313 deleted the patch-38 branch November 27, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@IEvangelist IEvangelist Awaiting requested review from IEvangelist IEvangelist is a code owner

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Milestone
November 2024
Development

Successfully merging this pull request may close these issues.
2 participants
@Youssef1313 @BillWagner