Skip to content

Fix Resource Monitoring sample app #47058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

evgenyfedorov2
Copy link
Member

@evgenyfedorov2 evgenyfedorov2 commented Jul 2, 2025

Summary

As mentioned here, the sample app outputs incorrect values over and over again.

The change fixes the sample by adding Host, which is necessary for the underlying BackgroundService in Resource Monitoring.


Internal previews

📄 File 🔗 Preview link
docs/core/diagnostics/diagnostic-resource-monitoring.md Resource monitoring

@evgenyfedorov2 evgenyfedorov2 requested review from tommcdon and a team as code owners July 2, 2025 08:55
@dotnetrepoman dotnetrepoman bot added this to the July 2025 milestone Jul 2, 2025
@kkostrzewa-coupa
Copy link

With this change, ctrl+c cancelation no longer works. I think the Console.CancelKeyPress event handler needs to be placed before the await AnsiConsole.Live(table)..., or else we get an infinite loop.

@evgenyfedorov2
Copy link
Member Author

With this change, ctrl+c cancelation no longer works. I think the Console.CancelKeyPress event handler needs to be placed before the await AnsiConsole.Live(table)..., or else we get an infinite loop.

Updated, thank you!

@evgenyfedorov2
Copy link
Member Author

@IEvangelist whenever you have time, could you please review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants