Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #10633 - multiple statements simplified by removing explicit comparison #10698

Merged
merged 10 commits into from
Nov 30, 2024

Conversation

robbyc073
Copy link
Contributor

Summary

Multiple if and while statements simplified by removing explicit comparison and replacing with logical NOT operator as required.

Fixes #10633

@robbyc073 robbyc073 requested a review from a team as a code owner November 20, 2024 22:28
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 20, 2024
@robbyc073
Copy link
Contributor Author

@dotnet-policy-bot agree

@robbyc073
Copy link
Contributor Author

@dotnet-policy-service agree

This comment was marked as outdated.

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - a few things to fix before we can merge.

robbyc073 and others added 3 commits November 25, 2024 22:11
…/Overview/scripts/jquery-1.5.1.js

Co-authored-by: Genevieve Warren <[email protected]>
…/Overview/scripts/jquery-1.5.1.js

Co-authored-by: Genevieve Warren <[email protected]>
…/Overview/scripts/jquery-ui-1.8.11.js

Co-authored-by: Genevieve Warren <[email protected]>

This comment was marked as outdated.

Robert Coleman added 2 commits November 25, 2024 22:33

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

Learn Build status updates of commit d148167:

✅ Validation status: passed

File Status Preview URL Details
snippets/common/VS_Snippets_WebNet/Classic RequiredFieldValidator Example/Common/source.xml ✅Succeeded View
snippets/cpp/VS_Snippets_CLR_System/system.GC.ReRegisterForFinalize Example/CPP/class1.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_CLR_System/system.Random.Next/CPP/next3.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_CLR_System/system.runtime.compilerservices.internalsvisibletoattribute/cpp/friend1.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_CLR_System/system.String.Format/cpp/formatexample2.cpp ✅Succeeded
snippets/cpp/VS_Snippets_CLR/AsyncDelegateExamples/cpp/polling.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_CLR/console.beep/CPP/beep.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_CLR/console.cursorvis/CPP/vis.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_CLR/console.keyavailable/CPP/ka.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_CLR/directoryinfocreatesub/CPP/directoryinfocreatesub.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_CLR/T.TryParse/CPP/tp.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/ClassicTcpClient.PublicMethodsAndPropertiesExample/CPP/source.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/DiscoveryDocument_DiscoveryDocument/CPP/discoverydocument_discoverydocument.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/DiscoveryExceptionDictionary_Property_Method/CPP/discoveryexceptiondictionary_property_method.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/DiscoveryReferenceCollection/CPP/discoveryreferencecollection.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/IChannelReceiver_StartListening_ChannelData/CPP/ichannelreceiver_channeldata_server.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/Message.Acknowledgment/CPP/message_acknowledgment.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/MessageQueue.Receive_TimeoutTransaction/CPP/mqreceive_timeouttransaction.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/MessageQueue.Receive_transaction/CPP/mqreceive_transaction.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/MessageQueue.Send_obj/CPP/mqsend_generic.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/MessageQueue.Send_ObjectTransaction/CPP/mqsend_objtransaction.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/NCLCredPolicy/CPP/NCLCredPolicy.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/NCLFtpClient/CPP/ftptests.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/NclMailASync/cpp/mailasync.cpp ✅Succeeded View
snippets/cpp/VS_Snippets_Remoting/NCLNetInfo2/CPP/networkexamples.cpp ✅Succeeded View

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit e6d5a9e into dotnet:main Nov 30, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poor (beginner) if statements
2 participants