-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #10633 - multiple statements simplified by removing explicit comparison #10698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dotnet-policy-bot agree |
@dotnet-policy-service agree |
This comment was marked as outdated.
This comment was marked as outdated.
gewarren
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - a few things to fix before we can merge.
snippets/cpp/VS_Snippets_Remoting/NclMailASync/cpp/mailasync.cpp
Outdated
Show resolved
Hide resolved
...csharp/System.IdentityModel.Tokens/IssuerNameRegistry/Overview/scripts/jquery-1.5.1-vsdoc.js
Outdated
Show resolved
Hide resolved
...csharp/System.IdentityModel.Tokens/IssuerNameRegistry/Overview/scripts/jquery-1.5.1-vsdoc.js
Outdated
Show resolved
Hide resolved
...csharp/System.IdentityModel.Tokens/IssuerNameRegistry/Overview/scripts/jquery-1.5.1-vsdoc.js
Outdated
Show resolved
Hide resolved
...csharp/System.IdentityModel.Tokens/IssuerNameRegistry/Overview/scripts/jquery-1.5.1-vsdoc.js
Outdated
Show resolved
Hide resolved
snippets/csharp/System.IdentityModel.Tokens/IssuerNameRegistry/Overview/scripts/jquery-1.5.1.js
Outdated
Show resolved
Hide resolved
snippets/csharp/System.IdentityModel.Tokens/IssuerNameRegistry/Overview/scripts/jquery-1.5.1.js
Outdated
Show resolved
Hide resolved
...s/csharp/System.IdentityModel.Tokens/IssuerNameRegistry/Overview/scripts/jquery-ui-1.8.11.js
Outdated
Show resolved
Hide resolved
...s/csharp/System.IdentityModel.Tokens/IssuerNameRegistry/Overview/scripts/jquery-ui-1.8.11.js
Outdated
Show resolved
Hide resolved
...rp/System.IdentityModel.Tokens/IssuerNameRegistry/Overview/scripts/microsoftmvcajax.debug.js
Outdated
Show resolved
Hide resolved
…/Overview/scripts/jquery-1.5.1.js Co-authored-by: Genevieve Warren <[email protected]>
…/Overview/scripts/jquery-1.5.1.js Co-authored-by: Genevieve Warren <[email protected]>
…/Overview/scripts/jquery-ui-1.8.11.js Co-authored-by: Genevieve Warren <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
…et-api-docs into robbyc073-changes Add changes made in GitHub conversation.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Rob <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
gewarren
approved these changes
Nov 26, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-Infrastructure
community-contribution
Indicates that the PR has been added by a community member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Multiple if and while statements simplified by removing explicit comparison and replacing with logical NOT operator as required.
Fixes #10633