Fix wording of ldloca description #11313
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
github-actions
bot
added
the
needs-area-label
gewarren
added
area-System.Reflection.Emit
and removed
needs-area-label
|
Could you please resolve the conflict? |
|
Thanks; done. |
|
Thank you! Could you please fix up #11314 as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current phrasing in the numbered list unambiguously and incorrectly means "dereference the local variable, which is guaranteed to contain an address, and push that address to the stack". The rest of the text correctly implies instead that it means "push the address of the local variable".
ECMA-335 6th edition states: