Fall out from #36502 #36550
Merged
Fall out from #36502 #36550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cincuranet
force-pushed
the
optional2
branch
2 times, most recently
from
42b6a82 to
6c7feaa
Compare
roji
approved these changes
Aug 14, 2025
src/EFCore.Relational/Query/Internal/RelationalProjectionBindingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Query/Internal/RelationalProjectionBindingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
cincuranet
force-pushed
the
optional2
branch
6 times, most recently
from
96611a5 to
79c139b
Compare
cincuranet
force-pushed
the
optional2
branch
5 times, most recently
from
e273964 to
a85a356
Compare
roji
reviewed
Aug 15, 2025
|
|
||
| /// <inheritdoc /> | ||
| public override StructuralTypeShaperExpression MakeClrTypeNullable() | ||
| => Type != Type.MakeNullable() |
There was a problem hiding this comment.
I know you're just following the common pattern here (that's good), but I've never understood why the inverse conditional logic, i.e. why not do:
=> Type == Type.MakeNullable()
? this
: new RelationalStructuralTypeShaperExpression(StructuralType, ValueBufferExpression, IsNullable, MaterializationCondition, Type.MakeNullable());One day I'll do a pass...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.