-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Rename Casual to Causal #7484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Rename Casual to Causal #7484
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR renames all occurrences of “Casual” to the correct “Causal” in class names, pipeline types, tests, samples, and utility methods.
- Rename model and pipeline types (e.g., Phi3ForCasualLM → Phi3ForCausalLM)
- Update related test and sample references
- Rename attention-mask helpers (e.g., MakeCasualMask → MakeCausalMask)
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/Microsoft.ML.GenAI.Phi/Phi3/Phi3ForCausalLM.cs | Renamed class and factory methods to “Causal” |
src/Microsoft.ML.GenAI.Phi/Phi2/Phi2ForCausalLM.cs | Renamed class and factory methods to “Causal” |
src/Microsoft.ML.GenAI.Core/Utility/AttentionMaskConverter.cs | Renamed casual→causal flags and mask builders |
test/**/*.cs | Updated tests to use new Causal classes |
docs//*.cs, docs//*.md | Updated samples and docs to reference “Causal” |
test/Microsoft.ML.GenAI.Core.Tests/Microsoft.ML.GenAI.Core.Tests.csproj | Updated removed test filename to Causal... |
Comments suppressed due to low confidence (1)
src/Microsoft.ML.GenAI.Phi/Phi3/Phi3ForCausalLM.cs:21
- Renaming public model classes (e.g., Phi3ForCasualLM → Phi3ForCausalLM) is a breaking change. Consider providing a deprecated alias or marking the old class as [Obsolete] to help downstream consumers migrate smoothly.
public class Phi3ForCausalLM : nn.Module<CausalLMModelInput, CausalLMModelOutput>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7484 +/- ##
==========================================
- Coverage 68.99% 68.98% -0.01%
==========================================
Files 1482 1482
Lines 273880 273880
Branches 28254 28254
==========================================
- Hits 188968 188949 -19
- Misses 77529 77550 +21
+ Partials 7383 7381 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
fix #7483