-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Fixed NRE when clearing ListView after navigating back #27274
Open
SubhikshaSf4851
wants to merge
4
commits into
dotnet:main
Choose a base branch
from
SubhikshaSf4851:newbranch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+136
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dotnet-policy-service agree company="Syncfusion, Inc." |
MartyIX
reviewed
Jan 22, 2025
src/Controls/src/Core/Compatibility/Handlers/ListView/Windows/ListViewRenderer.cs
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Jan 23, 2025
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue26498.cs
Outdated
Show resolved
Hide resolved
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
@SubhikshaSf4851 I have tried your fix on my repro (I logged 26577, which has been closed as duplicate of 26498) - and the fix does stop the error, thank you. |
/azp run |
This comment was marked as off-topic.
This comment was marked as off-topic.
/rebase |
a990728
to
016331b
Compare
jfversluis
reviewed
Feb 25, 2025
src/Controls/src/Core/Compatibility/Handlers/ListView/Windows/ListViewRenderer.cs
Outdated
Show resolved
Hide resolved
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue26498.cs
Outdated
Show resolved
Hide resolved
jfversluis
approved these changes
Feb 25, 2025
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-controls-collectionview
CollectionView, CarouselView, IndicatorView
community ✨
Community Contribution
partner/syncfusion
Issues / PR's with Syncfusion collaboration
platform/windows 🪟
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RootCause:
Description Of Change:
Tested the behaviour in the following platforms.
Issue Fixed:
Fixes #26498
Before Fix:
Issue26498BeforeFix.mp4
After Fix:
Issue26498AfterFix.mp4