-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Re-enabled flaky UI test TextInEditorShouldScroll #29167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hey there @@NirmalKumarYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
#if MACCATALYST | ||
App.ScrollDown("editor"); // To make sure the editor is scrolled down | ||
var yPos = yPosLabel.GetText(); | ||
Assert.That(yPos,Is.GreaterThan("0")); // The Y position should be greater than 0 after scrolling down |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note — since this is a UITest, ideally we should verify that scrolling is visually reflected in the UI. Relying on ContentOffset.Y > 0
introduces a logical check, but it doesn’t fully guarantee a visible change occurred on screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bhavanesh2001 , The test is to check whether the editor is scrollable or not. The previous UI test was flaky because the content was scrolled a pixel off from its original position. So instead of relying on a visual confirmation, I went with an alternative approach. The Y position label text will be updated only if the editor is scrolled. Otherwise it stays as 0.
This is added only to MAC to resolve flaky issue on CI.
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
Description of Change
TextInEditorShouldScroll
to verify scrolling behavior using ayPositionLabel
instead of relying on screenshot validation. This ensures the test is more deterministic and avoids flakiness in CI, particularly for macOS.Issues Fixed
Fixes #29025