Avoid synchronous I/O in BufferedReadStream #11379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanKrivanek
approved these changes
Feb 19, 2025
Comment on lines
+134
to
+146
| // Trying to read more data than the buffer can hold | ||
| int alreadyCopied = 0; | ||
| if (_currentlyBufferedByteCount > 0) | ||
| { | ||
| Array.Copy(_buffer, _currentIndexInBuffer, buffer, offset, _currentlyBufferedByteCount); | ||
| alreadyCopied = _currentlyBufferedByteCount; | ||
| _currentIndexInBuffer = 0; | ||
| _currentlyBufferedByteCount = 0; | ||
| } | ||
| #pragma warning disable CA1835 // Prefer the 'Memory'-based overloads for 'ReadAsync' and 'WriteAsync' | ||
| int innerReadCount = await _innerStream.ReadAsync(buffer, offset + alreadyCopied, count - alreadyCopied, cancellationToken); | ||
| #pragma warning restore CA1835 // Prefer the 'Memory'-based overloads for 'ReadAsync' and 'WriteAsync' | ||
| return innerReadCount + alreadyCopied; |
There was a problem hiding this comment.
Can this be extracted into inner function and reused in the last else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
Changes Made
Testing
Notes