-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPIKE] Add Json Communication Protocol #11458
Draft
YuliiaKovalova
wants to merge
16
commits into
dotnet:main
Choose a base branch
from
YuliiaKovalova:dev/ykovalova/update_communication_protocol
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[SPIKE] Add Json Communication Protocol #11458
YuliiaKovalova
wants to merge
16
commits into
dotnet:main
from
YuliiaKovalova:dev/ykovalova/update_communication_protocol
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ade4ae
to
8dc4afb
Compare
…/github.com/YuliiaKovalova/msbuild into dev/ykovalova/update_communication_protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the changes are made on the top of #11393
many files were touched due to changes in
internal static INodePacket FactoryForDeserialization(ITranslatorBase translator)
ITranslator -> ITranslatorBase
Summary
This PR introduces a new JSON-based protocol for communication with dotnet.exe in MSBuild, improving the extensibility and maintainability of our inter-process communication. The implementation includes new interfaces for JSON translation and packet handling, along with the necessary infrastructure to support this protocol.
Changes
ITranslatable2
interface extendingITranslatable
with JSON translation supportINodePacket2
interface implementingITranslatable2
for packet handlingJsonTranslator
classTaskHostConfiguration
andNodeBuildComplete
to implementINodePacket2
(these are registered byOutOfProcTaskHostNode
)NodeEndpointOutOfProcBase
to instantiateJsonTranslator
for .NET host scenariosImplementation Details
New Interfaces
Protocol Integration
The JSON protocol is instantiated in
NodeEndpointOutOfProcBase
whenisNetHost
is true, providing a clean separation between different communication protocols while maintaining backward compatibility.Breaking Changes
None. This is a backward-compatible change that introduces new functionality without affecting existing behavior.
OPEN QUESTIONS