Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Use JS interop to get full NativeName, DisplayName #110221

Draft
wants to merge 1 commit into
base: release/8.0-staging
Choose a base branch
from

Conversation

ilonatommy
Copy link
Member

Backport of ##99956 to release/8.0
Fixes #110035, #44739, #45951 in net8.

Customer Impact

Customers that use net8 don't have full form of DisplayName, EnglishName, they see e.g.: de (DE) instead of German (Germany). With this change they will be able to see the longer form.

  • Customer reported
  • Found internally

Regression

We intentionally shortened DisplayName, EnglishName to shrink ICU size and we kept it that way for some time. When we realized that JS API can give WASM app the missing globalization information, we leveraged it to revert the full form of DisplayName, EnglishName.

  • Yes
  • No

Testing

CI testing edited in this PR will be asserting this change.

Risk

Medium, this change involves unsafe code, icalls to JS. On the other hand, the backport is 1:1 and the change to net 9 was added relatively early in the release cycle.

I am leaving it as a draft until @lewing approves.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-System.Globalization os-browser Browser variant of arch-wasm labels Nov 27, 2024
@ilonatommy ilonatommy self-assigned this Nov 27, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-System.Globalization os-browser Browser variant of arch-wasm Servicing-consider Issue for next servicing release review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant