Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] Soft fingerprint for boot config #113762

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

maraf
Copy link
Member

@maraf maraf commented Mar 21, 2025

Before this change we apply only hard fingerprint on boot config if users opt-in (WasmFingerprintBootConfig or WriteImportMapToHtml).
This means that hosted blazor won't have soft fingerprint on boot config.

This PR adds soft fingerprint if wasm assets are to be fingerprinted (default behavior) and hard fingerprint if users opt-in.

Added comments

  • WasmFingerprintAssets
    • true = wasm assets will have hard fingerprint
    • false = wasm assets won't have even soft fingerprint
  • WasmFingerprintBootConfig
    • true = boot config will have hard fingerprint
    • false = boot config will have soft fingerprint
  • WasmFingerprintDotnetJs
    • true = dotnet.js will have hard fingerprint
    • false = dotnet.js will have soft fingerprint

Contributes to dotnet/aspnetcore#59456

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Mar 21, 2025
@maraf maraf added this to the 10.0.0 milestone Mar 21, 2025
@maraf maraf self-assigned this Mar 21, 2025
@Copilot Copilot bot review requested due to automatic review settings March 21, 2025 13:53

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/mono/nuget/Microsoft.NET.Sdk.WebAssembly.Pack/build/Microsoft.NET.Sdk.WebAssembly.Browser.targets: Language not supported
@maraf maraf merged commit f81d5dc into dotnet:main Mar 24, 2025
27 of 29 checks passed
@maraf maraf deleted the BrowserBootSoftFingerprint branch March 24, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants