Skip to content

Remove SLH-DSA OOM test #115341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

PranavSenthilnathan
Copy link
Member

CI tests are failing with OOM sometimes so removing a test that OOMs on purpose. The test intends to make sure resizing will not overflow by making sure that eventually it will terminate. However, even if it overflows, it will throw an exception and terminate the resize loop so it's not really testing anything useful.

@Copilot Copilot AI review requested due to automatic review settings May 6, 2025 16:43
@PranavSenthilnathan PranavSenthilnathan self-assigned this May 6, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes a test that intentionally triggered an OOM scenario to verify that a resize loop terminates via exception, as it was not providing meaningful coverage.

  • Removed ExportPkcs8PrivateKey_ResizeTerminates test to prevent intermittent CI failures
  • Consolidated test coverage to rely on exception handling already validated elsewhere
Comments suppressed due to low confidence (1)

src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaContractTests.cs:605

  • Removing the ExportPkcs8PrivateKey_ResizeTerminates test may reduce test coverage for verifying exception handling during resize operations. Please ensure that any critical exception handling behavior is covered by other tests.
[Theory]

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

@PranavSenthilnathan PranavSenthilnathan merged commit 1db7a9c into dotnet:main May 6, 2025
82 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants