Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for MSbuildProjectLoader.LoadProjectInfoAsync throwing on unrecognized project language #44928

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Nov 18, 2024

Port of #44927 to 1xx

Fixes #44908

Customer Impact

dotnet-watch fails to automatically switch to "auto-rebuild" mode for F# projects, which do not support Hot Reload. Restores 8.0 behavior.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

One-liner to fix read buffer bounds.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@tmat tmat requested a review from a team as a code owner November 18, 2024 17:30
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Nov 18, 2024
@tmat tmat changed the title Workaround for MSbuildProjectLoader.LoadProjectInfoAsync on unrecognized project language Workaround for MSbuildProjectLoader.LoadProjectInfoAsync throwing on unrecognized project language Nov 18, 2024
@leecow leecow added this to the 9.0.2 milestone Dec 12, 2024
@tmat tmat merged commit 20d85a1 into dotnet:release/9.0.1xx Dec 12, 2024
31 checks passed
@tmat tmat deleted the FSharp1xx branch December 12, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants