Do not build SDK installers in source-build #48322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
MichaelSimons
approved these changes
Apr 9, 2025
ViktorHofer
approved these changes
Apr 9, 2025
mmitche
approved these changes
Apr 9, 2025
jkoritzinsky
approved these changes
Apr 9, 2025
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installers (RPM/DEB) are currently built in source build. This is a regression introduced with #46896 That PR brought the installer infra to standards of other repos, i.e.
runtime.To condition installer build we now need to use the same model that is used in that repo, i.e. https://github.com/dotnet/runtime/blob/a6553ac646aa190f716787dcdf1dcc157b5f280b/src/installer/pkg/sfx/installers/dotnet-host.proj#L4