Skip to content

Update README to point SDK installer link to dotnet/dotnet repository #48821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 26, 2025

Conversation

v-wuzhai
Copy link
Member

@v-wuzhai v-wuzhai commented May 6, 2025

No description provided.

@v-wuzhai v-wuzhai marked this pull request as ready for review May 6, 2025 02:04
@Copilot Copilot AI review requested due to automatic review settings May 6, 2025 02:04
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the README to point users to the new SDK installer link in the dotnet/dotnet repository.

  • Removed the outdated link to the .NET SDK latest builds table.
  • Introduced a new link with updated instructions for installing the SDK.

README.md Outdated
Comment on lines 22 to 23
- [Official builds](https://dotnet.microsoft.com/download/dotnet)
- [**.NET SDK latest builds table**](documentation/package-table.md)
- For the latest SDK installers and installation instructions, see the [Installing the SDK section of the dotnet/dotnet repository](https://github.com/dotnet/dotnet#installing-the-sdk)
Copy link
Preview

Copilot AI May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider retaining a consistent bullet point format to match the surrounding list items for improved readability and consistency.

Copilot uses AI. Check for mistakes.

@v-wuzhai
Copy link
Member Author

v-wuzhai commented May 6, 2025

Please hold merging this PR until .NET 10 Preview 5 becomes the active preview version.

@v-wuzhai v-wuzhai requested a review from marcpopMSFT May 6, 2025 02:32
@KalleOlaviNiemitalo
Copy link
Contributor

This seems somewhat related to #48801 but does not clarify the daily builds table itself.

README.md Outdated
- [**.NET SDK latest builds table**](documentation/package-table.md)
- For the latest SDK installers and installation instructions, see the [Installing the SDK section of the dotnet/dotnet repository](https://github.com/dotnet/dotnet#installing-the-sdk)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably go straight to the build table as that's what this did before so just keep it simple like this:
.NET SDK latest builds table

@marcpopMSFT
Copy link
Member

@v-wuzhai We have forked for p5. Can you prepare the PR to the dotnet/dotnet repo for preview 5 and in this PR, can you remove the package-table.md (and double check if we have any other links to it from elsewhere)? Thanks.

@v-wuzhai
Copy link
Member Author

v-wuzhai commented May 23, 2025

@v-wuzhai We have forked for p5. Can you prepare the PR to the dotnet/dotnet repo for preview 5 and in this PR, can you remove the package-table.md (and double check if we have any other links to it from elsewhere)? Thanks.

Thanks for the reminder! I’ve made the following updates:

@v-wuzhai
Copy link
Member Author

@ViktorHofer @marcpopMSFT Could you help merge this? I don’t have permission.

@ViktorHofer ViktorHofer merged commit 12a7f16 into main May 26, 2025
5 of 7 checks passed
@ViktorHofer ViktorHofer deleted the dev/Jason/update-readme-sdk-install-link branch May 26, 2025 07:23
@KalleOlaviNiemitalo
Copy link
Contributor

The previous table also listed 9.0.3xx builds but the new table at https://github.com/dotnet/dotnet/blob/main/docs/builds-table.md doesn't.

@v-wuzhai
Copy link
Member Author

@KalleOlaviNiemitalo Because a stable release corresponding to the 9.0.3xx build is already available.
https://dotnet.microsoft.com/en-us/download/dotnet/9.0

@marcpopMSFT
Copy link
Member

To add additional information to v-wuzhai's response, we used to keep the in-support versions on the table but this would cause confusion with customers as the public versions would be missing changes from a bunch of upstream repos that customers expected. A few years ago, we changed that and decided to only keep the active branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants