Skip to content
This repository has been archived by the owner on Nov 28, 2019. It is now read-only.

Create strings.md #195

Merged
merged 1 commit into from
Jun 12, 2017
Merged

Create strings.md #195

merged 1 commit into from
Jun 12, 2017

Conversation

badersur
Copy link
Contributor

No description provided.

@ardalis
Copy link
Contributor

ardalis commented Jun 12, 2017

What does this achieve?

@badersur
Copy link
Contributor Author

Change than to that in the sentence below. I thought it's clear so I didn't leave an explanation! sorry about this.

For a little extra credit, support an optional third variable than can be set to either 'loud' or 'quiet'.

@ardalis
Copy link
Contributor

ardalis commented Jun 12, 2017

Ah, perfect, thanks. I didn't see that difference in the online diff tool.

@ardalis ardalis merged commit 2c01502 into dotnet:master Jun 12, 2017
@ardalis
Copy link
Contributor

ardalis commented Jun 12, 2017

Thanks!

@badersur
Copy link
Contributor Author

You're welcome :)
I noticed it's not clear so I should learn to explain my changes from now on!

I also think this was one of the reasons to file the old issue: #168

@badersur badersur deleted the patch-1 branch June 12, 2017 16:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants