Fixed AutomationProperties.Name for DatePicker Button #10949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
PR
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an accessibility issue by adding the missing AutomationProperties.Name attribute ("Show Calendar") to the DatePicker button.
- Updates the DatePicker button in all relevant theme files (Fluent, Fluent.Light, Fluent.HC, Fluent.Dark)
- Applies the same accessibility fix in the DatePicker.xaml style to improve compatibility with accessibility tools
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| Fluent.xaml | Added AutomationProperties.Name attribute to the DatePicker button |
| Fluent.Light.xaml | Updated DatePicker button for consistent accessibility naming |
| Fluent.HC.xaml | Fixed missing AutomationProperties.Name for accessibility compliance |
| Fluent.Dark.xaml | Unified accessibility property update for DatePicker button |
| DatePicker.xaml | Applied AutomationProperties.Name update in button style |
src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Themes/Fluent.xaml
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Themes/Fluent.Light.xaml
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Themes/Fluent.HC.xaml
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Themes/Fluent.Dark.xaml
Outdated
Show resolved
Hide resolved
src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/DatePicker.xaml
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10949 +/- ##
===================================================
+ Coverage 2.98754% 13.45583% +10.46829%
===================================================
Files 3319 3319
Lines 664894 664894
Branches 74674 74674
===================================================
+ Hits 19864 89467 +69603
+ Misses 644849 572878 -71971
- Partials 181 2549 +2368
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The "Show Calendar" button for DatePicker control did not have any name set to it, which causes issues for users using Accessibility Features in Windows.
Customer Impact
Customers using Accessibility Features in Windows, like Narrator, etc. will be able to use the control with ease.
Regression
No
Testing
Local app + Narrator testing
Risk
Minimal
Microsoft Reviewers: Open in CodeFlow