-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't crash when browser shutdown #1239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilonatommy
approved these changes
Jul 29, 2024
radekdoulik
approved these changes
Jul 29, 2024
maraf
approved these changes
Jul 29, 2024
/ba-g unrelated issues |
This was referenced Jul 29, 2024
this didn't flow to runtime yet? Log How do I trigger that ? |
Turns out the subscription was disabled, I reenabled it and dotnet/runtime#106128 has the update. |
ivanpovazan
added a commit
that referenced
this pull request
Sep 4, 2024
* [browser] don't crash during browser shutdown (#1239) * Update dependencies from https://github.com/dotnet/arcade build 20240725.3 (#1240) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 9.0.0-beta.24368.9 -> To Version 9.0.0-beta.24375.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20240801.1 (#1245) [main] Update dependencies from dotnet/arcade * [main] Update dependencies from dotnet/arcade (#1248) * Update dependencies from https://github.com/dotnet/arcade build 20240808.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 9.0.0-beta.24401.1 -> To Version 9.0.0-beta.24408.2 * Update dependencies from https://github.com/dotnet/arcade build 20240816.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 9.0.0-beta.24408.2 -> To Version 9.0.0-beta.24416.2 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20240821.2 (#1250) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 9.0.0-beta.24416.2 -> To Version 9.0.0-beta.24421.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/arcade build 20240823.2 (#1251) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 9.0.0-beta.24421.2 -> To Version 9.0.0-beta.24423.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * [WASI] HTTP server, exit code (#1244) * Update dependencies from https://github.com/dotnet/arcade build 20240830.1 (#1254) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 9.0.0-beta.24423.2 -> To Version 10.0.0-beta.24430.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> * Remove separate CodeQL pipeline (#1256) CodeQL runs in the main pipeline via 1ESPT now and can't be disabled so having a separate pipeline doesn't make sense. --------- Co-authored-by: Pavel Savara <[email protected]> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Alexander Köplinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/runtime#105370