Add ability to select path segments using Python re regexprs; follow on to PR#146 #177

AlainLich · 2022-12-13T11:17:50Z

Hi, this is a follow-on of my previous PR (#146) on same subject; apparently it was simpler for me to use a different branch.

This has run Action https://github.com/AlainLich/dpath-python/actions/runs/3684590771 in my branch AL-master4merge. I have added tests exercising this with most functions, and documented in README.rst

All details are in the list of commits, including documentation, tests,...

I hope this suits your needs, let me know if there are still issues for merging in the main baseline.

Recovered 1) tests/test_path_ext_py from PR submission 2) some github workflows used to validate PR submission

Follow-up PR: "Add ability to select path segments using Python re regexprs" dpath-maintainers#146 on June 1, 2021 Includes: - integration of extension on dpath-python - improvement of tests (under nose2, with scripts test/noseRunner to control code options) - improvement of documentation in README.rst Baseline for integration: commit ea64635 (tag: v2.1.1, origin/master, origin/HEAD, master, AL-master4merge) Merge: 702b5dd 38007df Author: moomoohk <[email protected]> Date: Wed Nov 30 17:16:05 2022 +0200 Note: at this time, no test wrt. Github.Actions has been made (yet)

Resolved conflicts: dpath/segments.py dpath/version.py Testing to be redone!

- tests improved and running locally - documentation updated Follow-up PR: "Add ability to select path segments using Python re regexprs" dpath-maintainers#146 on June 1, 2021 Baseline for merge: commit 45b3488 (tag: v2.1.2, origin/master, origin/HEAD, master) Author: moomoohk <[email protected]> Date: Mon Dec 5 09:52:05 2022 +0200

…ng action manually

…on enhancements 1) suppress dependency on mock now integrated as unittest.mock 2) avoids warnings concerning invalid escape sequences: either use raw strings or use double backslash: testing both 3) detailed the issue of such escape sequences in re.regexp in README.rst, giving example of both techniques No change in .yml: rerunning should resolve identified issues

…path for pypy - Improved Github actions (clean up, test under pypy3) - formatting in accordance with Flake8, deal with errors diagnosed by Flake but accepted by python3 - moved test tools to dir test-utils - tox.ini, flake.ini: avoid spurious diagnostics

…ing StringMatcher capability: 1) supports extension by re.regex (re.Pattern.match) 2) supports duck typed Duck_StringMatcher derived classes which permit user defined pattern matcher 3) included tests and documenation 4) dealt with Flake8 diagnostics Also found a random rare error in test_segments.test_view, left Pdb obtained information in the source file (see bottom of tests/test_segments.py). This corresponds with an unrealistic situation random generated by hypothesis, not easily reproducible for lack of random seed.

…ngMatcher extension

AlainLich · 2023-01-09T12:27:38Z

Hi @moomoohk

after looking at yesterday's tests, failure was apparently caused by lack of support for typing.Protocol, which implements https://peps.python.org/pep-0544/ , because pypy's version was older than the one I have been using.
I am preparing an improved version that supports both PEP-544 compliant and ignorant compilers, with a little bit more work for the user in the latter case.
Apparently most of the work TBD is in the testing, so don't expect a revised version before next week-end.

moomoohk · 2023-01-10T20:51:03Z

Hi Alain,
I've cleared enough from the backlog and now I'd like to focus on your PR.
After reviewing the changes you've made it's clear a lot of work has been put in and that's much appreciated.
That said, I feel that a lot of the changes included aren't within the scope of the feature addition you're proposing.

If the core functionality (adding regexes to paths) works well enough then I'd like to restructure this PR. I hope that's ok with you!

Perhaps the other changes can be considered separately.

Thanks.

AlainLich · 2023-01-10T21:35:25Z

Hi, a) I will be pushing a version that cleans up the functionality you probably are not interested in (using a class or a function to define matching). b) doing this, I have cleared the issues with running on (slightly) older versions of the Python or Pypy (which was more difficult/surprising). c) having a lot of tests helped, especially because the type identification for instances is subtle. So you should probably start with this forthcoming version, to clean up and see what you want to keep. For me, it is OK that you keep only the functionality you are interested in. ( Personally, I got interested in the example with Levenshtein approximate matching, when it seemed clear that this would be such a small change) Looking forwards to reading you Le mar. 10 janv. 2023 à 21:51, moomoohk ***@***.***> a écrit :

…

Hi Alain, I've cleared enough from the backlog and now I'd like to focus on your PR. After reviewing the changes you've made it's clear a lot of work has been put in and that's much appreciated. That said, I feel that a lot of the changes included aren't within the scope of the feature addition you're proposing. If the core functionality (adding regexes to paths) works well enough then I'd like to restructure this PR. I hope that's ok with you! Perhaps the other changes can be considered separately. Thanks. — Reply to this email directly, view it on GitHub <#177 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACWFOIQCUDDT25O7WUHZQI3WRXDUHANCNFSM6AAAAAAS5CSIO4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

AlainLich · 2023-01-11T11:36:27Z

Hi @moomoohk, After thinking about it, I think it will be simpler for you if I committed: a) a simplified version with only re regexp in the branch linked to the PR. This will keep only that functionality plus workarounds for working Pypy if required. b) another full featured version in a new branch, which includes what I have now and can be readied for a PR after some testing in Github's containers This plan should be simpler for you, since I know what I put in! Have a good day !😀 Le mar. 10 janv. 2023 à 22:35, Alain Lichnewsky ***@***.***> a écrit :

…

Hi, a) I will be pushing a version that cleans up the functionality you probably are not interested in (using a class or a function to define matching). b) doing this, I have cleared the issues with running on (slightly) older versions of the Python or Pypy (which was more difficult/surprising). c) having a lot of tests helped, especially because the type identification for instances is subtle. So you should probably start with this forthcoming version, to clean up and see what you want to keep. For me, it is OK that you keep only the functionality you are interested in. ( Personally, I got interested in the example with Levenshtein approximate matching, when it seemed clear that this would be such a small change) Looking forwards to reading you Le mar. 10 janv. 2023 à 21:51, moomoohk ***@***.***> a écrit : > Hi Alain, > I've cleared enough from the backlog and now I'd like to focus on your PR. > After reviewing the changes you've made it's clear a lot of work has been > put in and that's much appreciated. > That said, I feel that a lot of the changes included aren't within the > scope of the feature addition you're proposing. > > If the core functionality (adding regexes to paths) works well enough > then I'd like to restructure this PR. I hope that's ok with you! > > Perhaps the other changes can be considered separately. > > Thanks. > > — > Reply to this email directly, view it on GitHub > <#177 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ACWFOIQCUDDT25O7WUHZQI3WRXDUHANCNFSM6AAAAAAS5CSIO4> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> >

Deals with - issues testing with pypy (an possibly some older Pythons) - flake8 diagnostics Other developments to go to separate PR

AlainLich · 2023-01-12T16:09:55Z

Hi @moomoohk

a) this is fine, do you expect me to do anything?
b) while you are on this, could you make your workflow "deploy" dependent on your user name; the way things are set up now, each time I pull master for synchronising (and if the version has changed), it launches (under my name) and
fails as it should... and I get some spurious mail. ( https://github.com/AlainLich/dpath-python/actions/runs/3900678773)

Something like the following should work (not tried):

deploy:
   ... 
    # Check that this only occurs on maintainer repo
    if: ${{ github.actor == "dpath-maintainers" }}

Have a good day :-)

moomoohk · 2023-04-05T09:41:49Z

Hi Alain

Hi @moomoohk

a) this is fine, do you expect me to do anything? b) while you are on this, could you make your workflow "deploy" dependent on your user name; the way things are set up now, each time I pull master for synchronising (and if the version has changed), it launches (under my name) and fails as it should... and I get some spurious mail. ( https://github.com/AlainLich/dpath-python/actions/runs/3900678773)

Something like the following should work (not tried):
deploy:
   ... 
    # Check that this only occurs on maintainer repo
    if: ${{ github.actor == "dpath-maintainers" }} 
Have a good day :-)

Hi Alain,
I might have some time to go through your changes over the next few days.
I would much appreciate if you could open a separate PR/restructure this one to include the necessary changes for your proposed features.
I'll be glad to review miscellaneous infrastructure changes in a separate PR.
As it stands, the miscellaneous changes are blocking your feature.

Thanks and regards

moomoohk · 2023-04-05T09:24:04Z

dpath/options.py

+# https://peps.python.org/pep-0604/#isinstance-and-issubclass
+# https://bugs.python.org/issue44529
+
+try:


What is this check needed for?

moomoohk · 2023-04-05T09:24:41Z

dpath/segments.py

@@ -6,6 +6,12 @@
 from dpath.exceptions import InvalidGlob, InvalidKeyName, PathNotFound
 from dpath.types import PathSegment, Creator, Hints, Glob, Path, SymmetricInt

+import re
+try:


Dpath's minimum supported version is Python 3.7 making this check redundant

AlainLich · 2023-04-05T10:53:01Z

Hi @moomoohk,
I will try to look into this before the end of next week-end. I will send you a few questions about what to keep in the mean time. Will keep the bare minimum for the feature to work, and for tests, and prepare a PR based on current master commit.

For now:
a) do you want to always enable the feature ? to allow enabling/disablig by DPATH_ACCEPT_RE_REGEXP ?
b) I will review tests I have added for their usefulness

Regards

AlainLich · 2023-04-09T19:38:46Z

Hi @moomoohk
following your remarks, I submitted PR #186 as replacement for this one, with only required changes. This PR #177 can be closed.

You were right to spot not needed stuff, some that can be assumed for Python >= 3.7, others that were left from my exercise with duck-typed generalization.

Regards
Alain

moomoohk · 2023-04-14T12:48:03Z

May we close this PR for the time being?

AlainLich added 7 commits December 9, 2022 21:59

Preparing for integration of PR

2ba5326

Recovered 1) tests/test_path_ext_py from PR submission 2) some github workflows used to validate PR submission

Merge branch 'AL-PR-devel' into AL-master4merge

7924d5f

Resolved conflicts: dpath/segments.py dpath/version.py Testing to be redone!

Modifications in python3Test.yml for current Python version and runni…

98cf08a

…ng action manually

Correction in README.rst, bumped Pypy version in tox.ini

1a36acc

AlainLich mentioned this pull request Dec 13, 2022

Add ability to select path segments using Python re regexprs #146

Closed

moomoohk and others added 5 commits December 17, 2022 18:12

Merge branch 'master' into AL-master4merge

afc04ec

Used yamllint on 2 action workflows, corrected errors

e6a0d0d

Corrected tox.ini for testing, rapidfuzz is required for testing Stri…

6b4cabd

…ngMatcher extension

AlainLich and others added 4 commits January 11, 2023 17:49

Restrict PR to addifion of handling 're' regexp matches

e66a263

Deals with - issues testing with pypy (an possibly some older Pythons) - flake8 diagnostics Other developments to go to separate PR

Merge branch 'master' into AL-master4merge

bc277ba

Remove whitespace (flake8)

77a33c9

Remove unused import (flake8)

d0faa10

moomoohk reviewed Apr 5, 2023

View reviewed changes

AlainLich mentioned this pull request Apr 9, 2023

Add ability to select path segments using Python re regexprs; follow on to PR#146 & #177 #186

Open

AlainLich mentioned this pull request Apr 11, 2023

Add ability to select path segments with user defined match; follow on to PRs #146 & #177 #182

Open

moomoohk closed this Apr 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add ability to select path segments using Python re regexprs; follow on to PR#146 #177

Add ability to select path segments using Python re regexprs; follow on to PR#146 #177

Uh oh!

AlainLich commented Dec 13, 2022

Uh oh!

AlainLich commented Jan 9, 2023

Uh oh!

moomoohk commented Jan 10, 2023

Uh oh!

AlainLich commented Jan 10, 2023 via email

Uh oh!

AlainLich commented Jan 11, 2023 via email

Uh oh!

AlainLich commented Jan 12, 2023

Uh oh!

moomoohk commented Apr 5, 2023

Uh oh!

moomoohk Apr 5, 2023

Uh oh!

moomoohk Apr 5, 2023

Uh oh!

AlainLich commented Apr 5, 2023

Uh oh!

AlainLich commented Apr 9, 2023

Uh oh!

moomoohk commented Apr 14, 2023

Uh oh!

Uh oh!

Add ability to select path segments using Python re regexprs; follow on to PR#146 #177

Add ability to select path segments using Python re regexprs; follow on to PR#146 #177

Uh oh!

Conversation

AlainLich commented Dec 13, 2022

Uh oh!

AlainLich commented Jan 9, 2023

Uh oh!

moomoohk commented Jan 10, 2023

Uh oh!

AlainLich commented Jan 10, 2023 via email

Uh oh!

AlainLich commented Jan 11, 2023 via email

Uh oh!

AlainLich commented Jan 12, 2023

Uh oh!

moomoohk commented Apr 5, 2023

Uh oh!

moomoohk Apr 5, 2023

Choose a reason for hiding this comment

Uh oh!

moomoohk Apr 5, 2023

Choose a reason for hiding this comment

Uh oh!

AlainLich commented Apr 5, 2023

Uh oh!

AlainLich commented Apr 9, 2023

Uh oh!

moomoohk commented Apr 14, 2023

Uh oh!

Uh oh!