New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a tabs 'variant' property with 'outlined' option #1454

Open

bgilhome-now wants to merge 1 commit into dpc-sdp:develop from bgilhome-now:feature/1453-add-tabs-outlined-variant

+124 −2

Contributor

bgilhome-now commented Feb 17, 2025

Issue: PR for feature request #1453

What I did

Add a tabs 'variant' property with 'outlined' option, including relevant CSS & Storybook stories

How to test

Run the storybook task
Confirm new stories in Navigation -> Tabs (Outlined, Vertical outlined)
Confirm styling is correct

Checklist

For all PR's

I've added relevant changes to the project Readme if needed
I've updated the documentation site as needed
I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

I have added a storybook story covering all variants
I have checked a11y tab in storybook passes
I have added cypress component tests (if the component is interactive)
Any events are emitted on the event bus using emitRplEvent


          feat(@dpc-sdp/ripple-ui-core): add a tabs 'variant' property with 'ou…

3ae7fee

…tlined' option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet