Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-794] fix form submission (when using term select) #1465

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Mar 4, 2025

Issue: https://digital-vic.atlassian.net/browse/SD-794

What I did

  • Fix form submission (when using term select)

How to test

FE: https://app.pr-1188.vic-gov-au.sdp4.sdp.vic.gov.au/submit-your-grant
BE: develop.content

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@lambry lambry self-assigned this Mar 4, 2025
Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 4149f16
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/67c6763be1a9c600085b3189

Copy link

cypress bot commented Mar 4, 2025

ripple-framework    Run #2615

Run Properties:  status check passed Passed #2615  •  git commit 4149f169d4: fix(@dpc-sdp/ripple-tide-webform): fix form submission for forms using term sele...
Project ripple-framework
Branch Review bugfix/webform-term-select
Run status status check passed Passed #2615
Run duration 14m 14s
Commit git commit 4149f169d4: fix(@dpc-sdp/ripple-tide-webform): fix form submission for forms using term sele...
Committer David Featherston
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 239
View all changes introduced in this branch ↗︎

@lambry lambry changed the title fix(@dpc-sdp/ripple-tide-webform): fix form submission (when using term select) [SD-794] fix form submission (when using term select) Mar 4, 2025
@lambry lambry added this to the 2.27.0 milestone Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant