Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privatefile source for dataset #581

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

sharmasahil
Copy link
Contributor

Jira

https://digital-vic.atlassian.net/browse/SD-432

Problem/Motivation

Fix

Added custom private file source to upload directly to private files for csv and json.

Related PRs

Screenshots

TODO

@sharmasahil sharmasahil changed the title Privatfile source for dataset Privatefile source for dataset Jan 29, 2025
Copy link
Contributor

@anthony-malkoun anthony-malkoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sharmasahil lint is failing with fixable errors. Please fix these. Is there more to this PR? How does it look installed on a working site?

@sharmasahil
Copy link
Contributor Author

Hey @sharmasahil lint is failing with fixable errors. Please fix these. Is there more to this PR? How does it look installed on a working site?

Hey @anthony-malkoun, I have fixed the lint issue, on the working site you should be able to create a dataset with csv/json files being stored in private file directory e.g here you can see two different options for JSON and CSV private files:[https://nginx-php.pr-496.content-reference-sdp-vic-gov-au.sdp4.sdp.vic.gov.au/admin/content/datasets/add]

I am trying to sort the file creation issue, its not working in content reference private files folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants